[CP Staging] Fix: No notification when closing account #28800

tienifr · 2023-10-04T11:19:59Z

Details

No notification when account is closed. This PR fixes that.

Fixed Issues

$ #28748
PROPOSAL: #28748 (comment)

Tests

Login with any account
Go to Settings >> Security >> Close account
Enter your default contact method >> Close account >> Confirm
Verify you are logged out and a notification says "Account closed successfully"

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Login with any account
Go to Settings >> Security >> Close account
Enter your default contact method >> Close account >> Confirm
Verify you are logged out and a notification says "Account closed successfully"

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-compressed.mov

Mobile Web - Chrome

chrome-compressed.mov

Mobile Web - Safari

safari-compressed.mov

Desktop

desktop-compressed.mov

iOS

ios-compressed.mov

Android

android-compressed.mov

melvin-bot · 2023-10-04T11:37:33Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

abdulrahuman5196 · 2023-10-04T11:41:02Z

src/libs/Middleware/SaveResponseInOnyx.js

-        _.find(onyxUpdates, ({key, value}) => {
-            if (key !== ONYXKEYS.IS_USING_MEMORY_ONLY_KEYS || !value) {
-                return false;
+    return requestResponse


@tienifr Why are having this much diff here? I know we are only adding catch to this?

Can we remove the unwanted diff? Any specific reason to have?

That's prettier diff. Maybe because I added the catch phrase thus everything was shift down 1 line.

I've already compared line by line and verified that they're the same. You can check it yourself.

Thank you. I also verified. No changes.

abdulrahuman5196 · 2023-10-04T11:42:22Z

src/libs/Middleware/SaveResponseInOnyx.js

+                shouldPauseQueue: true,
+            });
+        })
+        .catch(console.error);


Kindly add small meaningful tags with error, like Got exception while saving response in onyx @tienifr

abdulrahuman5196 · 2023-10-04T12:23:08Z

Thank you checking

abdulrahuman5196 · 2023-10-04T12:40:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-04.at.5.54.06.PM.mp4

Mobile Web - Chrome

az_recorder_20231004_180214.mp4

Mobile Web - Safari

Screen.Recording.2023-10-04.at.5.57.17.PM.mp4

Desktop

Screen.Recording.2023-10-04.at.6.06.15.PM.mp4

iOS

Screen.Recording.2023-10-04.at.6.03.51.PM.mp4

Android

az_recorder_20231004_181901.mp4

mountiny

Thanks for quick fix

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

mountiny

Thanks everyone!

OSBotify · 2023-10-04T13:04:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] Fix: No notification when closing account (cherry picked from commit 130e6d6)

OSBotify · 2023-10-04T13:46:50Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 1.3.77-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-10-05T00:14:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-06T08:26:12Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

blazejkustra · 2023-10-06T13:24:52Z

src/libs/Middleware/SaveResponseInOnyx.js

+            });
+        })
+        .catch((err) => {
+            console.error('Got exception while saving response in Onyx', err);


This catch causes a regression, it suppresses network errors such as 'Failed to fetch', but I believe it shouldn't.

Unit tests defined in APITest.js are not failing due to a TypeError which is always raised in SequentialQueue file here:

First an error is suppressed in SaveResponseInOnyx:

console.error Got exception while saving response in Onyx Error: Failed to fetch at /tests/unit/APITest.js:90:40 52 | }) 53 | .catch((err) => { > 54 | console.error('Got exception while saving response in Onyx', err); | ^ 55 | }); 56 | 57 | export default SaveResponseInOnyx;

Later an error is raised as shouldPauseQueue isn't defined on undefined response:

error1 = TypeError: Cannot read properties of undefined (reading 'shouldPauseQueue') at /src/libs/Network/SequentialQueue.ts:73:26) at log (src/libs/Network/SequentialQueue.ts:81:21)

cc @mountiny @tienifr

blazejkustra · 2023-10-06T13:54:44Z

src/libs/Middleware/HandleUnusedOptimisticID.ts

+            if (!key) {
+                return;
+            }
+
            if (!key.startsWith(ONYXKEYS.COLLECTION.REPORT)) {


FYI optional chaining is allowed in TS:

Suggested change

if (!key) {

return;

}

if (!key.startsWith(ONYXKEYS.COLLECTION.REPORT)) {

if (!key?.startsWith(ONYXKEYS.COLLECTION.REPORT)) {

OSBotify · 2023-10-09T22:34:46Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T22:43:39Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-09T23:19:33Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.79-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

tienifr added 4 commits October 4, 2023 10:58

fix: 28748

36a58b9

catch error

f201b44

Merge branch 'main' of https://github.com/tienifr/App into fix/28748

b7e3dab

run prettier

b92d2bd

tienifr marked this pull request as ready for review October 4, 2023 11:37

tienifr requested a review from a team as a code owner October 4, 2023 11:37

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team October 4, 2023 11:37

tienifr mentioned this pull request Oct 4, 2023

[HOLD for payment 2023-10-20] [$500] Close account - There is no notification that account successfully closed #28748

Closed

6 tasks

abdulrahuman5196 reviewed Oct 4, 2023

View reviewed changes

detailed error message

8410b96

mountiny assigned tienifr Oct 4, 2023

mountiny changed the title ~~Fix: No notification when closing account~~ [CP Staging] Fix: No notification when closing account Oct 4, 2023

mountiny approved these changes Oct 4, 2023

View reviewed changes

abdulrahuman5196 approved these changes Oct 4, 2023

View reviewed changes

melvin-bot bot requested a review from mountiny October 4, 2023 12:56

mountiny approved these changes Oct 4, 2023

View reviewed changes

mountiny merged commit 130e6d6 into Expensify:main Oct 4, 2023
16 of 19 checks passed

OSBotify pushed a commit that referenced this pull request Oct 4, 2023

Merge pull request #28800 from tienifr/fix/28748

0d23434

[CP Staging] Fix: No notification when closing account (cherry picked from commit 130e6d6)

OSBotify mentioned this pull request Oct 4, 2023

Deploy Checklist: New Expensify 2023-10-03 #28727

Closed

OSBotify mentioned this pull request Oct 6, 2023

Deploy Checklist: New Expensify 2023-10-06 #28983

Closed

blazejkustra reviewed Oct 6, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] Fix: No notification when closing account #28800

[CP Staging] Fix: No notification when closing account #28800

tienifr commented Oct 4, 2023 •

edited

Loading

melvin-bot bot commented Oct 4, 2023

abdulrahuman5196 Oct 4, 2023 •

edited

Loading

tienifr Oct 4, 2023

tienifr Oct 4, 2023

abdulrahuman5196 Oct 4, 2023

abdulrahuman5196 Oct 4, 2023

tienifr Oct 4, 2023

tienifr Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023 •

edited

Loading

mountiny left a comment

abdulrahuman5196 left a comment

mountiny left a comment

OSBotify commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

blazejkustra Oct 6, 2023

mountiny Oct 6, 2023

blazejkustra Oct 6, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

[CP Staging] Fix: No notification when closing account #28800

[CP Staging] Fix: No notification when closing account #28800

Conversation

tienifr commented Oct 4, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 4, 2023

abdulrahuman5196 Oct 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Oct 4, 2023

abdulrahuman5196 commented Oct 4, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny left a comment

Choose a reason for hiding this comment

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Oct 4, 2023

OSBotify commented Oct 4, 2023

OSBotify commented Oct 5, 2023

OSBotify commented Oct 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

OSBotify commented Oct 9, 2023

tienifr commented Oct 4, 2023 •

edited

Loading

abdulrahuman5196 Oct 4, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 4, 2023 •

edited

Loading